Conversation
naveena456
requested review from
PandaeDo,
RolandJentschETAS,
aschemmel-tech,
masc2023 and
pahmann
as code owners
September 3, 2026 09:06
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Signed-off-by: Naveena Panne <naveenbellare@gmail.com>
Signed-off-by: Naveena Panne <pnn9kor@bosch.com>
Signed-off-by: Naveena Panne <pnn9kor@bosch.com>
Contributor
|
Documentation preview for this pull request is available at: |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are small, consistent, and include a passing-focused unit test plus the intended Bazel wiring for documentation code targets.
Pull request overview
This PR adds a minimal C++ “component example” implementation plus a GoogleTest target, and wires the component into the docs_bundle so documentation can reference/link to real code targets.
Changes:
- Added
make_hello_message()implementation and public header underscore/component_example/src/. - Added a
cc_testvalidating the expected greeting output. - Updated
score/component_example/BUILDto define acc_libraryand connect it to the docs bundle viacode_targets.
File summaries
| File | Description |
|---|---|
| score/component_example/tests/component_example_test.cpp | Adds a GoogleTest verifying make_hello_message() output. |
| score/component_example/src/component_example.hpp | Declares the example API function. |
| score/component_example/src/component_example.cpp | Implements the example API function. |
| score/component_example/BUILD | Introduces cc_library/cc_test targets and updates docs_bundle to use code_targets. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
MaximilianSoerenPollak
approved these changes
Sep 8, 2026
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
From Docs-AS-Code perspective this is correct.
masc2023
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created an actual code and test target to demonstrate the usage of docs_bundle.